Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix binary reader download duration histogram #8017

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix binary reader download duration histogram #8017

wants to merge 3 commits into from

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Dec 22, 2024 •
edited
Loading

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

  • Enable native histograms for thanos_indexheader_download_duration_seconds and thanos_indexheader_load_duration_seconds metrics.
  • We seem to accidentally use loadDuration histogram when we actually download the index header, which seems wrong. https://github.com/thanos-io/thanos/blob/main/pkg/block/indexheader/binary_reader.go#L575
  • When using newMemoryBinaryReader, we didn't track the latency to download index header there, this PR just puts the latency track inside WriteBinary to cover all cases.

Verification

@yeya24 yeya24 force-pushed the fix-binary-reader-download-duration branch from 4571381 to 95b68da Compare December 22, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yeya24